Accept compiler and flags from environment #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| @@ -20,22 +23,22 @@ ZOPFLIPNGBIN_SRC := src/zopflipng/zopflipng_bin.cc | |||
|
|
|||
| # Zopfli binary | |||
| zopfli: | |||
| $(CC) $(ZOPFLILIB_SRC) $(ZOPFLIBIN_SRC) $(CFLAGS) -o zopfli | |||
| $(CC) $(ZOPFLILIB_SRC) $(ZOPFLIBIN_SRC) $(CFLAGS) $(LDFLAFS) -o zopfli $(LIBS) | |||
|
CLAs look good, thanks! |
|
Did you see #92? |
Yes I did see it, it does not allow specifying compiler, and instead of := there is some funky "override CFLAGS" used. Last but not leas, current makefile does not handle LDFLAGS correctly, which is also fixed here. |
|
Seems this was at least partially taken care of in 4a35d30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packaging for distribution (such as openSUSE), distributions we want to specify CFLAGS/LDFLAGS and in some cases compiler as well.